I have had a discussion with @athei where he told me that changes to the API are already in the pipeline about a less expressive but still "good enough" API using a single seal_rent_deposit API to query the rent deposit with the current storage used for the contract. Note that this API would be called multiple times during a call. However, the good part is that this would not require manually calculating storage fees on the contract side.

Yes. I talked to @cmichi about that. I will look into the next iteration of the seal_rent_deposit API soon.

Codecov Report

Merging #755 (dec4434) into master (5571724) will increase coverage by 0.33%.
The diff coverage is 95.00%.

❗ Current head dec4434 differs from pull request most recent head c0d8931. Consider uploading reports for the commit c0d8931 to get more accurate results

@@            Coverage Diff             @@
##           master     #755      +/-   ##
==========================================
+ Coverage   83.33%   83.67%   +0.33%     
==========================================
  Files         163      163              
  Lines        7502     7496       -6     
==========================================
+ Hits         6252     6272      +20     
+ Misses       1250     1224      -26     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cfbe64...c0d8931. Read the comment docs.

@athei The comment is implemented, do you have anything else?

It was discussed here that no ink-unstable feature should be added. Maybe it should be removed.

It was discussed here that no ink-unstable feature should be added. Maybe it should be removed.

I get a bit sweaty when thinking about making the current rent API accessible without unstable flag. The reason is that in my mind it's pretty certain that we will have another iteration over the current status and not having it behind ink-unstable would mean that we e.g. have to mention it in the next rc changelog. Wdyt @Robbepop?

I thought a bit more about it and came to the conclusion that it's best to remove the unstable feature for rent stuff as well. My reasoning is that we are unstable in the rc state anyway and I also want to add examples soon and making them only available on unstable would make them more complicated. Also we might get community input by not hiding this behind a feature flag.